Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coingecko mapping for THOR token on Avalanche #1416

Closed
wants to merge 1 commit into from
Closed

Add coingecko mapping for THOR token on Avalanche #1416

wants to merge 1 commit into from

Conversation

onyb
Copy link
Collaborator

@onyb onyb commented May 10, 2022 •
edited
Loading

Summary

Disambiguate between Thor on Avalanche vs Thorswap on Ethereum

Internal discussions Slack

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Resolves brave/brave-browser#22651.

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

https://ratios.rewards.brave.com/v2/relative/provider/coingecko/thor/usd/1d should return Thor (Avalanche) price and not Thorswap (Ethereum) price.

@onyb
Add coingecko mapping for THOR token on Avalanche
14078bc 
Disambiguate between Thor on Avalanche vs Thorswap on Ethereum
@nvonpentz
Copy link
Contributor

Tested on dev

$ curl https://ratios.rewards.brave.software/v2/relative/provider/coingecko/thor/usd/1d

{"payload":{"thor":{"usd":7.14,"usd_timeframe_change":10.820245398520598}},"lastUpdated":"2022-05-10T17:33:07.834056155Z"}

@husobee
Copy link
Contributor

husobee commented May 12, 2022

#1420 so we can get ci to pass

@husobee husobee closed this May 12, 2022
@onyb onyb deleted the patch-1 branch May 12, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvonpentz nvonpentz nvonpentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Price of THOR is reporting wrong
3 participants
@onyb @nvonpentz @husobee